Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2238.
Makes the logic changed by #2520 flexible and usable by agents defined in the same application.
Supersedes #2251 because that did not get requested for review and adk-bot was not triggered there for some reason.
This is more generic and allows you to set http or https as needed, which is crucial in larger ecosystems.
And it lets you nest the FastAPI into a subapp, because you can specify the base url including the path of the sub-app.
If the
url
parameter in agent card is empty string, it will be filled from the application. This lets you either hardcode the agent url or let it be defined from the code.testing plan
The tests can be seen in the PR.
I removed the mock to actually exercise the A2A-related code which was just silently crashing until now.
Now, with this with, you can run
and the a2a agent will be exposed on the localhost. And if you will run the code in different environments, you can parameterize them now, and pass the URL e.g. from environment variable, which wasn't possible after merging #2520.